lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 04 Apr 2010 15:09:59 +0300 From: Timo Teräs <timo.teras@....fi> To: Herbert Xu <herbert@...dor.apana.org.au> CC: netdev@...r.kernel.org Subject: Re: [PATCH 1/4] flow: virtualize flow cache entry methods Herbert Xu wrote: > On Sun, Apr 04, 2010 at 07:26:36PM +0800, Herbert Xu wrote: >> Fine, move key into flow_cache_entry but the rest should still >> work, no? > > OK this doesn't work either as we still have NULL objects for > now. But I still think even if the ops pointer is the only > member in flow_cache_object, it looks better than returning the > nested ops pointer directly from flow_cache_lookup. Yes, it'll look better. I'll wrap the pointer in a struct. Ok, so far it's: - constify ops - indentation fixes for flow.c struct's with pointer members - wrap ops* in a struct* to avoid ops** Will fix and resend refreshed patches tomorrow. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists