lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 6 Apr 2010 13:22:49 +1000 From: Simon Horman <horms@...ge.net.au> To: wzt.wzt@...il.com Cc: linux-kernel@...r.kernel.org, Wensong Zhang <wensong@...ux-vs.org>, Julian Anastasov <ja@....bg>, netdev@...r.kernel.org, lvs-devel@...r.kernel.org, Patrick McHardy <kaber@...sh.net> Subject: Re: [PATCH] IPVS: replace sprintf to snprintf to avoid stack buffer overflow On Tue, Apr 06, 2010 at 10:50:20AM +0800, wzt.wzt@...il.com wrote: > IPVS not check the length of pp->name, use sprintf will cause stack buffer overflow. > struct ip_vs_protocol{} declare name as char *, if register a protocol as: > struct ip_vs_protocol ip_vs_test = { > .name = "aaaaaaaa....128...aaa", > .debug_packet = ip_vs_tcpudp_debug_packet, > }; > > when called ip_vs_tcpudp_debug_packet(), sprintf(buf, "%s TRUNCATED", pp->name); > will cause stack buffer overflow. > > Signed-off-by: Zhitong Wang <zhitong.wangzt@...baba-inc.com> I think that the simple answer is, don't do that. But your patch seems entirely reasonable to me. Acked-by: Simon Horman <horms@...ge.net.au> Patrick, please consider merging this. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists