lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 7 Apr 2010 11:21:09 -0500 From: Scott Wood <scottwood@...escale.com> To: Manfred Rudigier <Manfred.Rudigier@...cron.at> Cc: "'sandeep.kumar@...escale.com'" <sandeep.kumar@...escale.com>, "'netdev@...r.kernel.org'" <netdev@...r.kernel.org>, "'linuxppc-dev@...ts.ozlabs.org'" <linuxppc-dev@...ts.ozlabs.org> Subject: Re: [RFC PATCH net-next 2/4] gianfar: Added timer feature for eTSEC On Wed, Apr 07, 2010 at 11:46:24AM +0200, Manfred Rudigier wrote: > switch (config.tx_type) { > case HWTSTAMP_TX_OFF: > + priv->hwts_tx_en = 0; > break; > case HWTSTAMP_TX_ON: > + if (!(priv->device_flags & FSL_GIANFAR_DEV_HAS_TIMER)) > + return -ERANGE; > + priv->hwts_tx_en = 1; > return -ERANGE; > default: > return -ERANGE; > @@ -796,8 +802,12 @@ static int gfar_hwtstamp_ioctl(struct net_device *netdev, > > switch (config.rx_filter) { > case HWTSTAMP_FILTER_NONE: > + priv->hwts_rx_en = 0; > break; > default: > + if (!(priv->device_flags & FSL_GIANFAR_DEV_HAS_TIMER)) > + return -ERANGE; > + priv->hwts_rx_en = 1; > return -ERANGE; > } You need to acquire bflock (or avoid using bitfields for this), or you could race with the setting of wol_en or rx_csum_enable. -Scott -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists