netdev - Re: [PATCH net-next-2.6] drivers: net: use skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 14 Apr 2010 16:15:04 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next-2.6] drivers: net: use skb_headlen()

From: David Miller <davem@...emloft.net>
Date: Wed, 14 Apr 2010 15:59:49 -0700 (PDT)

> From: Eric Dumazet <eric.dumazet@...il.com>
> Date: Tue, 13 Apr 2010 22:48:20 +0200
> 
>> replaces (skb->len - skb->data_len) occurrences by skb_headlen(skb)
>> 
>> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>
> 
> Applied, thanks Eric.

Eric, there were several typos in this patch and it is clear
that even e1000 wasn't build tested.

You used the mystical "skb_headsize()" instead of "skb_headlen()"
in several locations.

I fixed this up, but please build test your changes no matter
how seemingly trivial next time.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html