lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 15 Apr 2010 11:08:47 +0800 From: Changli Gao <xiaosuo@...il.com> To: "David S. Miller" <davem@...emloft.net> Cc: Tom Herbert <therbert@...gle.com>, Eric Dumazet <eric.dumazet@...il.com>, netdev@...r.kernel.org, Changli Gao <xiaosuo@...il.com> Subject: Re: [PATCH] net: fix softnet_stat On Thu, Apr 15, 2010 at 11:01 AM, Changli Gao <xiaosuo@...il.com> wrote: > fix softnet_stat > > Per cpu variable softnet_data.total was shared between IRQ and SoftIRQ context > without any protection. And enqueue_to_backlog should update the netdev_rx_stat > of the target CPU. > > This patch changes the meaning of softnet_data.total to the number of packets > processed, not includes dropped, in order to avoid it sharing between IRQ and > SoftIRQ. And softnet_data.dropped is protected in the corresponding > input_pkt_queue.lock, if RPS is enabled. > I forget a comment: This patch also fixed a bug: packets received by enqueue_to_backlog() was counted twice: one in enqueue_to_backlog(), and one in __netif_receive_skb(), although they may not on the same CPUs. -- Regards, Changli Gao(xiaosuo@...il.com) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists