lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 15 Apr 2010 15:47:26 +0800 From: Changli Gao <xiaosuo@...il.com> To: David Miller <davem@...emloft.net> Cc: eric.dumazet@...il.com, therbert@...gle.com, eparis@...hat.com, netdev@...r.kernel.org Subject: Re: BUG: using smp_processor_id() in preemptible [00000000] code: avahi-daemon: caller is netif_rx On Thu, Apr 15, 2010 at 3:37 PM, David Miller <davem@...emloft.net> wrote: > From: Changli Gao <xiaosuo@...il.com> > Date: Thu, 15 Apr 2010 15:30:44 +0800 > >> Should netif_rx() be used only when preemption is disabled? If not, >> netif_rx_ni() should be used instead.? > > netif_rx() must be invoked from a hardware or software interrupt, > which implies preemption disabled. > > In netif_rx_ni(), the "ni" means "not interrupt". > yea, I know netif_rx_ni()'s meaning. It means that the following changes aren't necessary. #else - cpu = smp_processor_id(); + ret = enqueue_to_backlog(skb, get_cpu()); + put_cpu(); ret = enqueue_to_backlog(skb, smp_processor_id()); should be OK. #endif - - return enqueue_to_backlog(skb, cpu); + return ret; } -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists