lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 20 Apr 2010 14:48:53 +0200 From: Franco Fichtner <franco@...tsummer.de> To: Eric Dumazet <eric.dumazet@...il.com> CC: Changli Gao <xiaosuo@...il.com>, David Miller <davem@...emloft.net>, therbert@...gle.com, netdev@...r.kernel.org Subject: Re: [PATCH net-next-2.6] rps: consistent rxhash Eric Dumazet wrote: > In case we compute a software skb->rxhash, we can generate a consistent > hash : Its value will be the same in both flow directions. > > This helps some workloads, like conntracking, since the same state needs > to be accessed in both directions. > > tbench + RFS + this patch gives better results than tbench with default > kernel configuration (no RPS, no RFS) > > Also fixed some sparse warnings. > > Signed-off-by: Eric Dumazet <eric.dumazet@...il.com> > --- I thought about this for some time... Do we really need the port numbers here at all? A simple addr1^addr2 can provide a good enough pointer for distribution amongst CPUs. The real connection tracking is better done locally at the corresponding CPU. That way a potential cache miss can be avoided and the still needed hash calculation for connection tracking will be offloaded. Franco -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists