lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 20 Apr 2010 21:20:09 -0400 (EDT) From: Mikulas Patocka <mpatocka@...hat.com> To: David Miller <davem@...emloft.net> cc: netdev@...r.kernel.org, kaber@...sh.net Subject: Re: crash with bridge and inconsistent handling of NETDEV_TX_OK On Tue, 20 Apr 2010, David Miller wrote: > From: Mikulas Patocka <mpatocka@...hat.com> > Date: Tue, 20 Apr 2010 21:10:04 -0400 (EDT) > > > I see, but GRO is turned off on my interfaces, according to ethtool. > > GRO is just a flag bit, so it's possible that if your kernel is too > old ethtool will always show that it's off. > > If you haven't turned off GRO explicitly, then it's a good bet that > this is why it looks like it's off. And GRO is on by default. I have kernel 2.6.34-rc4, ethtool 2.6.33 and GRO is off. I haven't turned it off, I left it on default. > I still contend, therefore, that it's completely normal to see GSO > packet processing in the TX code path, even with bridging, and > therefore seeing the GSO code path get taken is not indicative of some > bug wrt. ->ndo_start_xmit() return value flag bit handling. Mikulas -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists