netdev - Re: [PATCH -next 1/3] bnx2: Add GRO support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 05 May 2010 00:49:11 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	mchan@...adcom.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH -next 1/3] bnx2: Add GRO support.

From: "Michael Chan" <mchan@...adcom.com>
Date: Tue, 4 May 2010 22:21:44 -0700

> Signed-off-by: Michael Chan <mchan@...adcom.com>
> Signed-off-by: Matt Carlson <mcarlson@...adcom.com>

Please turn it on by default by setting NETIF_F_GRO in your probe
routine.

I don't want a precedent started where we have drivers that support
GRO but don't enable it by default.  If there are some performance
degradations, we fix them instead of deferring the issue by not
enabling it by default in some awkward selection of drivers.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html