netdev - Re: [PATCH (v2)] bridge: update sysfs link names if port device names have changed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 6 May 2010 12:11:07 -0700
From:	Stephen Hemminger <shemminger@...ux-foundation.org>
To:	Simon Arlott <simon@...e.lp0.eu>
Cc:	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH (v2)] bridge: update sysfs link names if port device
 names have changed

On Thu, 06 May 2010 20:01:44 +0100
Simon Arlott <simon@...e.lp0.eu> wrote:

> +
> +	case NETDEV_CHANGENAME:
> +		err = br_sysfs_renameif(p);
> +		if (err)
> +			return NOTIFY_BAD;
> +		break;

I think you want:
 if (err)
	return notifier_from_errno(err);


+	err = sysfs_rename_link(br->ifobj, &p->kobj,
+		p->sysfs_name, p->dev->name);
+	if (err) {
+		printk(KERN_ERR "%s: unable to rename sysfs link %s to %s (%d)",
+			br->dev->name, p->sysfs_name, p->dev->name, err);

This should not be KERN_ERR but KERN_NOTICE, and use new wrapper macros.

	if (err)
		netdev_notice(br->dev, "unable to rename sysfs link %s to %s".
			 p->sysfs_name, p->dev->name, err)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html