lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 12 May 2010 14:40:28 +0100 From: Ian Campbell <ian.campbell@...rix.com> To: netdev@...r.kernel.org Cc: Ian Campbell <ian.campbell@...rix.com>, Stephen Hemminger <shemminger@...ux-foundation.org>, Jeremy Fitzhardinge <jeremy.fitzhardinge@...rix.com>, "David S. Miller" <davem@...emloft.net>, stable@...nel.org Subject: [PATCH] arp_notify: generate broadcast ARP reply not request. The arp_notify option causes us to send a broadcast ARP request with the host IP address in both the source and destination IP address fields. More usually a gratuitous ARP packet is a broadcast ARP reply with a broadcast destination IP and the local IP as the source The documentation of the arp_notify option in Documentation/networking/ip-sysctl.txt suggests this was the original intention therefore switch it over. Signed-off-by: Ian Campbell <ian.campbell@...rix.com> Cc: Stephen Hemminger <shemminger@...ux-foundation.org> Cc: Jeremy Fitzhardinge <jeremy.fitzhardinge@...rix.com> Cc: David S. Miller <davem@...emloft.net> Cc: netdev@...r.kernel.org Cc: stable@...nel.org --- net/ipv4/devinet.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c index 90e3d63..e26f723 100644 --- a/net/ipv4/devinet.c +++ b/net/ipv4/devinet.c @@ -1087,10 +1087,10 @@ static int inetdev_event(struct notifier_block *this, unsigned long event, struct in_ifaddr *ifa = in_dev->ifa_list; if (ifa) - arp_send(ARPOP_REQUEST, ETH_P_ARP, - ifa->ifa_address, dev, - ifa->ifa_address, NULL, - dev->dev_addr, NULL); + arp_send(ARPOP_REPLY, ETH_P_ARP, + INADDR_BROADCAST, dev, + ifa->ifa_address, + NULL, NULL, dev->dev_addr); } break; case NETDEV_DOWN: -- 1.5.6.5 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists