lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 12 May 2010 23:32:38 -0700 (PDT) From: David Miller <davem@...emloft.net> To: jeffrey.t.kirsher@...el.com Cc: netdev@...r.kernel.org, gospo@...hat.com, bruce.w.allan@...el.com Subject: Re: [net-next-2.6 PATCH 11/12] e1000e: Fix/cleanup PHY reset code for ICHx/PCHx From: Jeff Kirsher <jeffrey.t.kirsher@...el.com> Date: Mon, 10 May 2010 18:02:32 -0700 > From: Bruce Allan <bruce.w.allan@...el.com> > > i) Fixes a bug where e1000_sw_lcd_config_ich8lan() was calling > e1000_lan_init_done_ich8lan() to poll the STATUS.LAN_INIT_DONE bit to > make sure the MAC had completed the PHY configuration. However, > e1000_lan_init_done_ich8lan() had already been called in one of the two > places where PHY reset occurs for ICHx/PCHx parts, which caused the second > call to busy-wait for 150 msec because the LAN_INIT_DONE bit had already > been checked and cleared. > > ii) Cleanup the two separate PHY reset code paths, i.e. the full-chip reset > in e1000_reset_hw_ich8lan() and the PHY-only reset in > e1000_phy_hw_reset_ich8lan(). There was duplicate code in both paths to be > performed post-reset that are now combined into one new function - > e1000_post_phy_reset_ich8lan(). This cleanup also included moving the > clearing of the PHY Reset Asserted bit in the STATUS register (now done for > all ICH/PCH parts) and the check for the indication from h/w that basic > configuration has completed back to where it previously was in > e1000_get_cfg_done_ich8lan(). > > iii) Corrected a few comments > > Signed-off-by: Bruce Allan <bruce.w.allan@...el.com> > Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists