lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 13 May 2010 13:28:26 -0700 From: Chris Wright <chrisw@...hat.com> To: Scott Feldman <scofeldm@...co.com> Cc: davem@...emloft.net, netdev@...r.kernel.org, chrisw@...hat.com, arnd@...db.de Subject: Re: [net-next-2.6 V6 PATCH 1/2] Add netlink support for virtual port management (was iovnl) * Scott Feldman (scofeldm@...co.com) wrote: > From: Scott Feldman <scofeldm@...co.com> > > Add new netdev ops ndo_{set|get}_vf_port to allow setting of > port-profile on a netdev interface. Extends netlink socket RTM_SETLINK/ > RTM_GETLINK with new sub cmd called IFLA_VF_PORT (added to end of > IFLA_cmd list). > > A port-profile is used to configure/enable the external switch virtual port > backing the netdev interface, not to configure the host-facing side of the > netdev. A port-profile is an identifier known to the switch. How port- > profiles are installed on the switch or how available port-profiles are > made know to the host is outside the scope of this patch. > > There are two types of port-profiles specs in the netlink msg. The first spec > is for 802.1Qbg (pre-)standard, VDP protocol. The second spec is for devices > that run a similar protocol as VDP but in firmware, thus hiding the protocol > details. In either case, the specs have much in common and makes sense to > define the netlink msg as the union of the two specs. For example, both specs > have a notition of associating/deassociating a port-profile. And both specs > require some information from the hypervisor manager, such as client port > instance ID. > > The general flow is the port-profile is applied to a host netdev interface > using RTM_SETLINK, the receiver of the RTM_SETLINK msg communicates with the > switch, and the switch virtual port backing the host netdev interface is > configured/enabled based on the settings defined by the port-profile. What > those settings comprise, and how those settings are managed is again > outside the scope of this patch, since this patch only deals with the > first step in the flow. > > There is a RTM_GETLINK cmd to to return port-profile setting of an > interface and to also return the status of the last port-profile > association. > > IFLA_VF_PORT is modeled after the existing IFLA_VF_* cmd where a > VF number is passed in to identify the virtual function (VF) of an SR-IOV- > capable device. In this case, the target of IFLA_VF_PORT msg is the > netdev physical function (PF) device. The PF will apply the port-profile > to the VF. IFLA_VF_PORT can also be used for devices that don't > adhere to SR-IOV and can apply the port-profile directly to the netdev > target. In this case, the VF number is ignored. > > Passing in a NULL port-profile is used to delete the port-profile association. > > Acked-by: Arnd Bergmann <arnd@...db.de> > Signed-off-by: Scott Feldman <scofeldm@...co.com> > Signed-off-by: Roopa Prabhu<roprabhu@...co.com> Nice, this looks good to me. Acked-by: Chris Wright <chrisw@...hat.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists