netdev - Re: [PATCH -next] bnx2: Use netif_carrier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 17 May 2010 17:34:56 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	mchan@...adcom.com
Cc:	sgruszka@...hat.com, netdev@...r.kernel.org
Subject: Re: [PATCH -next] bnx2: Use netif_carrier_off() to prevent timeout.

From: "Michael Chan" <mchan@...adcom.com>
Date: Thu, 13 May 2010 07:48:35 -0700

> Based on original patch from Stanislaw Gruszka <sgruszka@...hat.com>.
> 
> Using netif_carrier_off() is better than updating all the ->trans_start
> on all the tx queues.
> 
> netif_carrier_off() needs to be called after bnx2_disable_int_sync()
> to guarantee no race conditions with the serdes timers that can
> modify the carrier state.
> 
> If the chip or phy is reset, carrier will turn back on when we get the
> link interrupt.  If there is no reset, we need to turn carrier back on
> in bnx2_netif_start().  Again, the phy_lock prevents race conditions with
> the serdes timers.
> 
> Signed-off-by: Michael Chan <mchan@...adcom.com>
> Signed-off-by: Matt Carlson <mcarlson@...adcom.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html