lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 19 May 2010 16:58:31 -0700 From: Tom Herbert <therbert@...gle.com> To: Changli Gao <xiaosuo@...il.com> Cc: davem@...emloft.net, eric.dumazet@...il.com, netdev@...r.kernel.org Subject: Re: [PATCH] net: fix problem in dequeuing from input_pkt_queue >> napi->weight = weight_p; >> - local_irq_disable(); >> while (work < quota) { >> struct sk_buff *skb; >> unsigned int qlen; >> >> while ((skb = __skb_dequeue(&sd->process_queue))) { >> - local_irq_enable(); > > we need to keep local irq disabled. If not, flush_backlog may be > called, and it will access sd->process_queue. > It should be okay? process_backlog only runs in softirq so bottom halves are already disabled, and I don't think flush_backlog runs out of an interrupt. > > -- > Regards, > Changli Gao(xiaosuo@...il.com) > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists