lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 24 May 2010 08:29:30 +0800
From:	Thomas Chou <thomas@...ron.com.tw>
To:	Dan Carpenter <error27@...il.com>
CC:	netdev@...r.kernel.org
Subject: Re: null dereference in ethoc_probe()

Dan Carpenter wrote:
> The patch 0baa080c75c: "ethoc: use system memory as buffer" introduced a
> potential null dereference.
> 
>   1060  free:
>   1061          if (priv->dma_alloc)
>                     ^^^^^^^^^^^^^^^
> 	priv can be null here.
> 
>   1062                  dma_free_coherent(NULL, priv->dma_alloc, priv->membase,
>   1063                          netdev->mem_start);
>   1064          free_netdev(netdev);
> 
> Also I think the error handling is not as complete as it should be.  It
> seems like we should call devm_iounmap() and release some of the other
> resources as well.
> 
> regards,
> dan carpenter
> 
> 
> 
Hi Dan,

Thank you for reporting this bug. I will submit patch to fix this mistake.

Best regards,
Thomas
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists