lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 27 May 2010 12:01:57 +0530 From: Sarveshwar Bandi <sarveshwarb@...verengines.com> To: Dan Carpenter <error27@...il.com> Cc: Sathya Perla <sathyap@...verengines.com>, Subbu Seetharaman <subbus@...verengines.com>, Ajit Khaparde <ajitk@...verengines.com>, "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org, kernel-janitors@...r.kernel.org Subject: Re: [patch 1/2] be2net: add unlock on error path Thanks Acked-by: Sarveshwar Bandi <sarveshwarb@...verengines.com> On 26/05/10 16:46 +0200, Dan Carpenter wrote: > The unlock accidentally got removed from the error path in dd131e76e5: > "be2net: Bug fix to avoid disabling bottom half during firmware upgrade." > > Signed-off-by: Dan Carpenter <error27@...il.com> > > diff --git a/drivers/net/benet/be_cmds.c b/drivers/net/benet/be_cmds.c > index c911bfb..18d5789 100644 > --- a/drivers/net/benet/be_cmds.c > +++ b/drivers/net/benet/be_cmds.c > @@ -1429,7 +1429,7 @@ int be_cmd_write_flashrom(struct be_adapter *adapter, struct be_dma_mem *cmd, > wrb = wrb_from_mccq(adapter); > if (!wrb) { > status = -EBUSY; > - goto err; > + goto err_unlock; > } > req = cmd->va; > sge = nonembedded_sgl(wrb); > @@ -1457,7 +1457,10 @@ int be_cmd_write_flashrom(struct be_adapter *adapter, struct be_dma_mem *cmd, > else > status = adapter->flash_status; > > -err: > + return status; > + > +err_unlock: > + spin_unlock_bh(&adapter->mcc_lock); > return status; > } > > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@...r.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists