lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 30 May 2010 13:35:51 -0400 From: Jeff Garzik <jeff@...zik.org> To: davem@...emloft.net, romieu@...zoreil.com, netdev@...r.kernel.org Subject: Re: [Patch]8139too: remove unnecessary cast of ioread32()'s return value On 05/30/2010 08:22 AM, Junchang Wang wrote: > ioread32() returns a 32-bit integer on all platforms. > There is no need to cast its return value. > > Signed-off-by: Junchang Wang<junchangwang@...il.com> > --- > drivers/net/8139too.c | 8 ++++---- > 1 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/8139too.c b/drivers/net/8139too.c > index 4ba7293..cc7d462 100644 > --- a/drivers/net/8139too.c > +++ b/drivers/net/8139too.c > @@ -662,7 +662,7 @@ static const struct ethtool_ops rtl8139_ethtool_ops; > /* read MMIO register */ > #define RTL_R8(reg) ioread8 (ioaddr + (reg)) > #define RTL_R16(reg) ioread16 (ioaddr + (reg)) > -#define RTL_R32(reg) ((unsigned long) ioread32 (ioaddr + (reg))) > +#define RTL_R32(reg) ioread32 (ioaddr + (reg)) Have you verified this matches all architectures definition of readl()? Jeff -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists