lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 30 May 2010 15:34:51 -0700 (PDT) From: David Miller <davem@...emloft.net> To: jeff@...zik.org Cc: romieu@...zoreil.com, netdev@...r.kernel.org Subject: Re: [Patch]8139too: remove unnecessary cast of ioread32()'s return value From: Jeff Garzik <jeff@...zik.org> Date: Sun, 30 May 2010 13:35:51 -0400 > Have you verified this matches all architectures definition of > readl()? Jeff, when you come out of hiding after months if not years of not reviewing network driver changes, could you provide some useful commentary instead of some trite stuff like this? It does match, that's why I told this person to write these patches. And if you have been following the thread where we discussed this, you wouldn't feel the need to ask this question about these two patches. And if it doesn't match, that's an arch bug which should be fixed and in any event there is only one possibility of a non-match and that is if the routine returns "unsigned long" Which, surprise surprise Jeff, retains current behavior! So there is no risk whatsoever possible from this change. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists