netdev - Re: [PATCH] drivers/net/arcnet/capmode.c: clean up code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 31 May 2010 00:35:39 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	daniel@...aq.de
Cc:	linux-kernel@...r.kernel.org, tj@...nel.org, jkosina@...e.cz,
	cl@...ux-foundation.org, joe@...ches.com, netdev@...r.kernel.org
Subject: Re: [PATCH] drivers/net/arcnet/capmode.c: clean up code

From: Daniel Mack <daniel@...aq.de>
Date: Mon, 31 May 2010 09:31:10 +0200

>  - shuffle around functions to get rid of forward declarations
>  - fix some CodingStyle and indentation issues
>  - last but not least, get rid of the following CONFIG_MODULE=n warning:
> 
> 	drivers/net/arcnet/capmode.c:52: warning: ‘capmode_proto’ defined but not used
> 
> Signed-off-by: Daniel Mack <daniel@...aq.de>

Applied, but:

> +MODULE_LICENSE("GPL");
> +
> -- 
> 1.7.1
> 

Extraneous empty line at end of file, which GIT warned about.
I fixed it up before applying your patch.

Thanks.