netdev - Re: [PATCH net-2.6] bnx2: Fix hang during rmmod bnx2.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 02 Jun 2010 02:27:27 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	mchan@...adcom.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-2.6] bnx2: Fix hang during rmmod bnx2.

From: "Michael Chan" <mchan@...adcom.com>
Date: Tue, 1 Jun 2010 18:05:36 -0700

> The regression is caused by:
> 
> commit 4327ba435a56ada13eedf3eb332e583c7a0586a9
>     bnx2: Fix netpoll crash.
> 
> If ->open() and ->close() are called multiple times, the same napi structs
> will be added to dev->napi_list multiple times, corrupting the dev->napi_list.
> This causes free_netdev() to hang during rmmod.
> 
> We fix this by calling netif_napi_del() during ->close().
> 
> Also, bnx2_init_napi() must not be in the __devinit section since it is
> called by ->open().
> 
> Signed-off-by: Michael Chan <mchan@...adcom.com>
> Signed-off-by: Benjamin Li <benli@...adcom.com>

Applied, thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html