netdev - Re: [PATCH][RFC] Infrastructure for compact call location representation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 8 Jun 2010 11:59:54 -0700
From:	David VomLehn <dvomlehn@...co.com>
To:	Randy Dunlap <rdunlap@...otime.net>
Cc:	to@...mlehn-lnx2.corp.sa.net, netdev@...r.kernel.org
Subject: Re: [PATCH][RFC] Infrastructure for compact call location
	representation

On Tue, Jun 08, 2010 at 08:44:52AM -0700, Randy Dunlap wrote:
> On Mon, 7 Jun 2010 17:30:52 -0700 David VomLehn wrote:
> 
> > Notes
> > o	Under simple test conditions, the number of call site IDs allocated
> > 	can be quite small, small enough to fit in 6 bits. That would reduce
> > 	the sk_buff growth to one byte. This is *not* a recommended
> > 	configuration.
> > o	This is placed in net/core and linux/net since those are the only
> > 	current users, but there is nothing about this that is networking-
> > 	specific.
> 
> => this shouldn't end up in net/

I was hesitant to do so, but I've now moved the header files
to include/linux/ and the C file to lib/. This makes more sense to me.

The rest of your comments were bang on; I've made all of the changes you
suggested. Thanks!
> ---
> ~Randy
> *** Remember to use Documentation/SubmitChecklist when testing your code ***

-- 
David VL
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html