lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 08 Jun 2010 09:06:04 +0300 From: Timo Teräs <timo.teras@....fi> To: Francois Romieu <romieu@...zoreil.com> CC: hayeswang <hayeswang@...ltek.com>, netdev@...r.kernel.org, davem@...emloft.net Subject: Re: [PATCH] r8169: fix random mdio_write failures On 06/08/2010 12:51 AM, Francois Romieu wrote: > hayeswang <hayeswang@...ltek.com> : >> Our hardware engineer suggests that check the completed indication >> per 100 micro seconds. And it needs 20 micro seconds delay after the >> completed indication for the next command. > > Should we do the same for mdio_read as well (100 us per iteration + > an extra 20 us) ? Well, doing 100us per iteration will increase the latency that the code notices "write complete" which slows down things. It'll also slightly decrease bus traffic which is good. But I'd be just fine with 25us per iteration. It sounds unlikely that polling the status register would slow down the actual write operation (if that is the case then 100us would be desirable). Changing my 25us to 20us would good. The original 25us was just a guess. The comment should be probably also updated that those delays are from realtek hw specs then. Would you like me to send a patch? - Timo -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists