lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 8 Jun 2010 02:20:06 -0700 From: "Dmitry Kravkov" <dmitry@...adcom.com> To: "netdev@...r.kernel.org" <netdev@...r.kernel.org> cc: "Ben Hutchings" <bhutchings@...arflare.com> Subject: RE: [PATCH 11/12] sfc: Only count bad packets in rx_errors Hi, Different drivers include different errors in stats->rx_errors: bxn2 bnx2x ixgbx sfc dnet atlx ---------------------------------------------------------------------- rx_length rx_length rx_length rx_length rx_length rx_length rx_over rx_over rx_over rx_frame rx_frame rx_frame rx_frame rx_frame rx_crc rx_crc rx_crc rx_crc rx_crc rx_fifo rx_fifo rx_missed rx_missed rx_symbol unsup_opcd ---------------------------------------------------------------------- Is there any documentation which defines what should this statistic include? Thanks Dmitry -----Original Message----- From: netdev-owner@...r.kernel.org [mailto:netdev-owner@...r.kernel.org] On Behalf Of Ben Hutchings Sent: Wednesday, June 02, 2010 12:21 AM To: David Miller Cc: netdev@...r.kernel.org; linux-net-drivers@...arflare.com Subject: [PATCH 11/12] sfc: Only count bad packets in rx_errors rx_errors is defined as 'bad packets received', but we are currently including various overflow errors as well. Signed-off-by: Ben Hutchings <bhutchings@...arflare.com> --- drivers/net/sfc/efx.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/drivers/net/sfc/efx.c b/drivers/net/sfc/efx.c index aae3347..26b0cc2 100644 --- a/drivers/net/sfc/efx.c +++ b/drivers/net/sfc/efx.c @@ -1518,11 +1518,8 @@ static struct net_device_stats *efx_net_stats(struct net_device *net_dev) stats->tx_window_errors = mac_stats->tx_late_collision; stats->rx_errors = (stats->rx_length_errors + - stats->rx_over_errors + stats->rx_crc_errors + stats->rx_frame_errors + - stats->rx_fifo_errors + - stats->rx_missed_errors + mac_stats->rx_symbol_error); stats->tx_errors = (stats->tx_window_errors + mac_stats->tx_bad); -- 1.6.2.5 -- Ben Hutchings, Senior Software Engineer, Solarflare Communications Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists