netdev - Re: [patch] enic: cleanup vic_provinfo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 10 Jun 2010 11:22:49 +0200
From:	walter harms <wharms@....de>
To:	Dan Carpenter <error27@...il.com>
CC:	Scott Feldman <scofeldm@...co.com>,
	Vasanthy Kolluri <vkolluri@...co.com>,
	Roopa Prabhu <roprabhu@...co.com>, netdev@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [patch] enic: cleanup vic_provinfo_alloc()



Dan Carpenter schrieb:
> If oui were a null variable then vic_provinfo_alloc() would leak memory.
> But this function is only called from one place and oui is not null so 
> I removed the check.
> 
> I also moved the memory allocation down a line so it was easier to spot.
> (No one ever reads variable declarations).
> 
> Signed-off-by: Dan Carpenter <error27@...il.com>
> 
> diff --git a/drivers/net/enic/vnic_vic.c b/drivers/net/enic/vnic_vic.c
> index d769772..0a35085 100644
> --- a/drivers/net/enic/vnic_vic.c
> +++ b/drivers/net/enic/vnic_vic.c
> @@ -25,9 +25,10 @@
>  
>  struct vic_provinfo *vic_provinfo_alloc(gfp_t flags, u8 *oui, u8 type)
>  {
> -	struct vic_provinfo *vp = kzalloc(VIC_PROVINFO_MAX_DATA, flags);
> +	struct vic_provinfo *vp;
>  
> -	if (!vp || !oui)
> +	vp = kzalloc(VIC_PROVINFO_MAX_DATA, flags);
> +	if (!vp)
>  		return NULL;
>  
>  	memcpy(vp->oui, oui, sizeof(vp->oui));
> --


This looks like memdup() ?

re,
 wh
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html