lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 13 Jun 2010 18:21:10 -0700 (PDT) From: David Miller <davem@...emloft.net> To: jeffrey.t.kirsher@...el.com Cc: netdev@...r.kernel.org, gospo@...hat.com, andy@...yhouse.net, sgruszka@...hat.com, stable@...nel.org Subject: Re: [net-2.6 PATCH] ixgbe: fix automatic LRO/RSC settings for low latency From: Jeff Kirsher <jeffrey.t.kirsher@...el.com> Date: Fri, 11 Jun 2010 15:47:03 -0700 > From: Andy Gospodarek <andy@...yhouse.net> > > This patch added to 2.6.34: > > commit f8d1dcaf88bddc7f282722ec1fdddbcb06a72f18 > Author: Jesse Brandeburg <jesse.brandeburg@...el.com> > Date: Tue Apr 27 01:37:20 2010 +0000 > > ixgbe: enable extremely low latency > > introduced a feature where LRO (called RSC on the hardware) was disabled > automatically when setting rx-usecs to 0 via ethtool. Some might not > like the fact that LRO was disabled automatically, but I'm fine with > that. What I don't like is that LRO/RSC is automatically enabled when > rx-usecs is set >0 via ethtool. > > This would certainly be a problem if the device was used for forwarding > and it was determined that the low latency wasn't needed after the > device was already forwarding. I played around with saving the state of > LRO in the driver, but it just didn't seem worthwhile and would require > a small change to dev_disable_lro() that I did not like. > > This patch simply leaves LRO disabled when setting rx-usecs >0 and > requires that the user enable it again. An extra informational message > will also now appear in the log so users can understand why LRO isn't > being enabled as they expect. > > Inconsistency of LRO setting first noticed by Stanislaw Gruszka. > > Signed-off-by: Andy Gospodarek <andy@...yhouse.net> > CC: Stanislaw Gruszka <sgruszka@...hat.com> > CC: stable@...nel.org > Tested-by: Stephen Ko <stephen.s.ko@...el.com> > Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists