netdev - Re: [PATCH] KVM: add schedule check to napi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 14 Jun 2010 14:44:17 -0600
From:	"Bruce Rogers" <brogers@...ell.com>
To:	"Herbert Xu" <herbert@...dor.apana.org.au>
Cc:	<rusty@...tcorp.com.au>, <netdev@...r.kernel.org>
Subject: Re: [PATCH] KVM: add schedule check to napi_enable call

 >>> On 6/6/2010 at 03:40 AM, Herbert Xu <herbert@...dor.apana.org.au> wrote: 
> Bruce Rogers <brogers@...ell.com> wrote:
>> Please consider this patch for the 2.6.32, 2.6.33, and 2.6.34 stable trees 
> as well as current development trees. (I've only tested on 2.6.32 however)
>> 
>>    virtio_net: Add schedule check to napi_enable call
>>    Under harsh testing conditions, including low memory, the guest would
>>    stop receiving packets. With this patch applied we no longer see any
>>    problems in the driver while performing these tests for extended periods
>>    of time.
>> 
>>    Make sure napi is scheduled subsequent to each napi_enable.
>> 
>>    Signed-off-by: Bruce Rogers <brogers@...ell.com>
>>    Signed-off-by: Olaf Kirch <okir@...e.de>
>>    Acked-by: Rusty Russell <rusty@...tcorp.com.au>
>>    Cc: stable@...nel.org
> 
> Looks good to me.
> 
> Thanks!


Thanks for the review.

We are hoping to get this into our 2.6.32 based sle11 sp1 maintenance update. Are there any concerns with this patch?

Bruce

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html