lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 15 Jun 2010 12:08:48 +0400 From: Pavel Emelyanov <xemul@...nvz.org> To: "Eric W. Biederman" <ebiederm@...ssion.com> CC: David Miller <davem@...emloft.net>, Serge Hallyn <serue@...ibm.com>, Linux Containers <containers@...ts.osdl.org>, Daniel Lezcano <daniel.lezcano@...e.fr>, netdev@...r.kernel.org Subject: Re: [PATCH 6/8] scm: Capture the full credentials of the scm sender. > +static __inline__ void scm_destroy_cred(struct scm_cookie *scm) > +{ > + put_pid(scm->pid); > + scm->pid = NULL; > + > + if (scm->cred) > + put_cred(scm->cred); > + scm->cred = NULL; > +} > + > static __inline__ void scm_destroy(struct scm_cookie *scm) > { > + scm_destroy_cred(scm); > if (scm && scm->fp) > __scm_destroy(scm); > } I'm a bit worried by the "if (scm" check. It makes me think scm can be NULL here and thus scm_destroy_cred can oops. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists