netdev - Re: [PATCH v5] netfilter: Xtables: idletimer target implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 15 Jun 2010 15:34:12 +0300
From:	Luciano Coelho <luciano.coelho@...ia.com>
To:	ext Patrick McHardy <kaber@...sh.net>
Cc:	"netfilter-devel@...r.kernel.org" <netfilter-devel@...r.kernel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"jengelh@...ozas.de" <jengelh@...ozas.de>,
	Timo Teras <timo.teras@....fi>
Subject: Re: [PATCH v5] netfilter: Xtables: idletimer target implementation

On Tue, 2010-06-15 at 13:54 +0200, ext Patrick McHardy wrote:
> Two final comments:
> 
> Luciano Coelho wrote:
> > diff --git a/include/linux/netfilter/xt_IDLETIMER.h b/include/linux/netfilter/xt_IDLETIMER.h
> > new file mode 100644
> > index 0000000..3e1aa1b
> > --- /dev/null
> > +++ b/include/linux/netfilter/xt_IDLETIMER.h
> 
> This file needs to be added to Kbuild to make sure it gets installed
> during "make headers_install".

Yes, thanks for pointing out.  I'll add it.


> > +static void idletimer_tg_destroy(const struct xt_tgdtor_param *par)
> > +{
> > +	const struct idletimer_tg_info *info = par->targinfo;
> > +
> > +	pr_debug("destroy targinfo %s\n", info->label);
> > +
> > +	mutex_lock(&list_mutex);
> > +	if (!info->timer) {
> >   
> 
> This doesn't seem to be possible.

As usual, you're right.  I'll remove this useless check.

v6 coming soon!

-- 
Cheers,
Luca.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html