netdev - Re: [net-next-2.6 PATCH 10/10] enic: Clean ups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 25 Jun 2010 20:49:32 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	vkolluri@...co.com
Cc:	netdev@...r.kernel.org, scofeldm@...co.com, roprabhu@...co.com
Subject: Re: [net-next-2.6 PATCH 10/10] enic: Clean ups

From: Vasanthy Kolluri <vkolluri@...co.com>
Date: Thu, 24 Jun 2010 13:52:26 -0700

> diff --git a/drivers/net/enic/vnic_wq.c b/drivers/net/enic/vnic_wq.c
> index 3ab7fa5..5c84bb8 100644
> --- a/drivers/net/enic/vnic_wq.c
> +++ b/drivers/net/enic/vnic_wq.c
> @@ -1,5 +1,5 @@
>  /*
> - * Copyright 2008 Cisco Systems, Inc.  All rights reserved.
> + * Copyright 2008-2010 Cisco Systems, Inc.  All rights reserved.
>   * Copyright 2007 Nuova Systems, Inc.  All rights reserved.
>   *
>   * This program is free software; you may redistribute it and/or modify
> @@ -22,7 +22,6 @@
>  #include <linux/types.h>
>  #include <linux/pci.h>
>  #include <linux/delay.h>
> -#include <linux/slab.h>
>  
>  #include "vnic_dev.h"
>  #include "vnic_wq.h"

I have to remove this otherwise the build breaks:

drivers/net/enic/vnic_wq.c: In function 'vnic_wq_alloc_bufs':
drivers/net/enic/vnic_wq.c:39:3: error: implicit declaration of function 'kzalloc'
drivers/net/enic/vnic_wq.c:39:15: warning: assignment makes pointer from integer without a cast
drivers/net/enic/vnic_wq.c: In function 'vnic_wq_free':
drivers/net/enic/vnic_wq.c:79:3: error: implicit declaration of function 'kfree'
  CC [M]  drivers/net/sfc/mcdi_mac.o
make[3]: *** [drivers/net/enic/vnic_wq.o] Error 1
make[3]: *** Waiting for unfinished jobs....
  CC [M]  drivers/net/sfc/selftest.o
  CC [M]  drivers/net/sfc/ethtool.o
  CC [M]  drivers/net/sfc/qt202x_phy.o
drivers/net/enic/vnic_rq.c: In function 'vnic_rq_alloc_bufs':
drivers/net/enic/vnic_rq.c:39:3: error: implicit declaration of function 'kzalloc'
drivers/net/enic/vnic_rq.c:39:15: warning: assignment makes pointer from integer without a cast
drivers/net/enic/vnic_rq.c: In function 'vnic_rq_free':
drivers/net/enic/vnic_rq.c:79:3: error: implicit declaration of function 'kfree'

Any time you remove any header includes, it is very wise to attempt a wide
assortment of build tests using all sorts of different configurations.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html