lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 29 Jun 2010 15:43:29 +0100 From: Ben Hutchings <bhutchings@...arflare.com> To: Stanislaw Gruszka <sgruszka@...hat.com> Cc: netdev@...r.kernel.org, Amerigo Wang <amwang@...hat.com> Subject: Re: [PATCH -next] sfc: set/clear NETIF_F_RXHASH bit directly On Tue, 2010-06-29 at 16:35 +0200, Stanislaw Gruszka wrote: > Signed-off-by: Stanislaw Gruszka <sgruszka@...hat.com> [...] I don't think this is a positive change. Please change ethtool_op_set_flags; then in efx_ethtool_set_flags() you can do: - if (data & ~supported) - return -EOPNOTSUPP; - - return ethtool_op_set_flags(net_dev, data); + return ethtool_op_set_flags(net_dev, data, supported); Ben. -- Ben Hutchings, Senior Software Engineer, Solarflare Communications Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists