netdev - Re: [PATCH] igbvf: avoid name clash between PF and VF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 30 Jun 2010 12:57:01 +0200
From:	Stefan Assmann <sassmann@...hat.com>
To:	Ben Hutchings <bhutchings@...arflare.com>
CC:	netdev <netdev@...r.kernel.org>, e1000-devel@...ts.sourceforge.net,
	"Duyck, Alexander H" <alexander.h.duyck@...el.com>,
	gregory.v.rose@...el.com, jeffrey.t.kirsher@...el.com,
	Andy Gospodarek <gospo@...hat.com>, kay.sievers@...y.org,
	harald@...hat.com
Subject: Re: [PATCH] igbvf: avoid name clash between PF and VF

On 30.06.2010 12:44, Ben Hutchings wrote:
> On Wed, 2010-06-30 at 10:53 +0200, Stefan Assmann wrote:
>> From: Stefan Assmann <sassmann@...hat.com>
>>
>> It looks like the VFs get initialized before all the PFs are. Therefore
>> the udev mapping MAC <-> ethX (for PFs) gets screwed because the VFs
>> may grab the ethX interface names (reserved by udev) for the PFs.
>>
>> Example:
>> igb max_vfs=0
>> eth0      Link encap:Ethernet  HWaddr 00:13:20:F7:A5:9E
>> eth1      Link encap:Ethernet  HWaddr 00:13:20:F7:A5:9F
>> eth2      Link encap:Ethernet  HWaddr 00:13:20:F7:A5:A0
>> eth3      Link encap:Ethernet  HWaddr 00:13:20:F7:A5:A1
>> igb max_vfs=1
>> eth0      Link encap:Ethernet  HWaddr 00:13:20:F7:A5:9E
>> eth1      Link encap:Ethernet  HWaddr 0A:CF:41:69:F7:A9
>> eth2      Link encap:Ethernet  HWaddr 3A:FE:20:4C:2A:3B
>> eth3      Link encap:Ethernet  HWaddr C6:C3:B1:56:C9:A4
>> eth3_rename Link encap:Ethernet  HWaddr 00:13:20:F7:A5:9F
>> eth4      Link encap:Ethernet  HWaddr 6E:8A:8A:A3:5F:69
>> eth4_rename Link encap:Ethernet  HWaddr 00:13:20:F7:A5:A0
>> eth5_rename Link encap:Ethernet  HWaddr 00:13:20:F7:A5:A1
>>
>> In the example above VF 0A:CF:41:69:F7:A9 grabs eth1 but udev
>> has a rule that says eth1 should be assigned PF 00:13:20:F7:A5:9F
>> (eth3_rename) and waits for the VF to disappear to rename eth3_rename
>> to eth1. Unfortunately eth1 is not going to disappear.
>> This is not a udev bug since udev doesn't create persistent rules for
>> VFs as their MAC address changes every reboot.
> [...]
> 
> I think it is a bug in the udev rules: udev should rename the VFs even
> though their names won't be persistent.

In that case let's Cc udev people.

  Stefan
--
Stefan Assmann         | Red Hat GmbH
Software Engineer      | Otto-Hahn-Strasse 20, 85609 Dornach
                       | HR: Amtsgericht Muenchen HRB 153243
                       | GF: Brendan Lane, Charlie Peters,
sassmann at redhat.com |     Michael Cunningham, Charles Cachera
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html