lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 08 Jul 2010 17:55:16 +0200 From: Patrick McHardy <kaber@...sh.net> To: Ben Hutchings <bhutchings@...arflare.com> CC: Eric Dumazet <eric.dumazet@...il.com>, David Miller <davem@...emloft.net>, netdev <netdev@...r.kernel.org> Subject: Re: [PATCH v2] vlan: allow TSO setting on vlan interfaces Ben Hutchings wrote: > On Thu, 2010-07-08 at 16:43 +0100, Ben Hutchings wrote: > >> On Thu, 2010-07-08 at 11:39 +0200, Eric Dumazet wrote: >> >>> When we need to shape traffic with low speeds, we need to disable tso on >>> network interface : >>> >>> ethtool -K eth0.2240 tso off >>> >>> It seems vlan interfaces miss the set_tso() ethtool method. >>> Propagating tso changes from lower device is not always wanted, some >>> vlans want TSO on, others want TSO off. >>> > [...] > >> I think the vlan driver should also have a netdev notifier to handle >> feature changes on the underlying device. >> > > To clarify, I think offload features should be disabled on a vlan device > if they are later disabled on the underlying device. Propagating > changes to enable features, as you say, might not be wanted. I agree. The VLAN driver should also propagate feature changes upwards itself. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists