netdev - Re: [PATCH net-next-2.6] xfrm: cleanup of xfrm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 14 Jul 2010 17:59:55 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	ramirose@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next-2.6] xfrm: cleanup of xfrm_input.c.

From: Rami Rosen <ramirose@...il.com>
Date: Wed, 14 Jul 2010 11:18:41 +0300

> Hi,
>  The patch removes unneeded inclusion of header files
> (linux/module.h, linux/netdevice.h, net/dst.h and net/ip.h)
>  in net/xfrm/xfrm_input.c
> 
> Regards,
> Rami Rosen
> 
> Signed-off-by: Rami Rosen <ramirose@...il.com>

If you do this, I also want to see you add includes for things like
linux/skbuff.h since data structures such as "struct sk_buff"
are used in this file.

Otherwise, this is how we end up with obscure build failures on
some configurations and not others, either now or in the future
when a similar change is made to some header file.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html