netdev - Re: [B.A.T.M.A.N.] [PATCH] net: Add batman-adv meshing protocol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 20 Jul 2010 20:49:30 +0200
From:	Sven Eckelmann <sven.eckelmann@....de>
To:	Abraham Arce <abraham.arce.moreno@...il.com>
Cc:	Marek Lindner <lindner_marek@...oo.de>,
	b.a.t.m.a.n@...ts.open-mesh.org,
	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	siwu@....tu-chemnitz.de
Subject: Re: [B.A.T.M.A.N.] [PATCH] net: Add batman-adv meshing protocol

Abraham Arce wrote:
> Minor comments...
> 
> 1. Is it ok to have a README in drivers directory? why not moving it
> to Documentation/networking?

Thanks, I will check if Documentation/networking is a better place.

> 2. Compilation error, one extra arguments passed
> 
> - stats = (struct net_device_stats *)dev_get_stats(skb->dev, &temp);
> + stats = (struct net_device_stats *)dev_get_stats(skb->dev, &temp);
> 
>   LD      kernel/built-in.o
> net/batman-adv/hard-interface.c: In function 'batman_skb_recv':
> net/batman-adv/hard-interface.c:482: error: too many arguments to
> function 'dev_get_stats'
> make[2]: *** [net/batman-adv/hard-interface.o] Error 1
> make[2]: *** Waiting for unfinished jobs....
> make[1]: *** [net/batman-adv] Error 2
> make: *** [net] Error 2

Do you use linux-next or net-next-2.6? Because this is needed to get it 
compiled as dev_get_stats was changed some time ago (commit 
28172739f0a276eb8d6ca917b3974c2edb036da3), but this is not part of 2.6.35.

Best regards,
	Sven

Download attachment "signature.asc " of type "application/pgp-signature" (837 bytes)