netdev - Re: [PATCH] e1000e: Drop a useless statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 21 Jul 2010 13:37:28 -0700
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Jean Delvare <jdelvare@...e.de>
Cc:	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
	Auke Kok <auke-jan.h.kok@...el.com>,
	Bruce Allan <bruce.w.allan@...el.com>,
	Jesse Brandeburg <jesse.brandeburg@...el.com>
Subject: Re: [PATCH] e1000e: Drop a useless statement

On Tue, Jul 20, 2010 at 08:30, Jean Delvare <jdelvare@...e.de> wrote:
> err is set again a few lines below.
>
> Signed-off-by: Jean Delvare <jdelvare@...e.de>
> Cc: Auke Kok <auke-jan.h.kok@...el.com>
> Cc: Bruce Allan <bruce.w.allan@...el.com>
> Cc: Jesse Brandeburg <jesse.brandeburg@...el.com>
> ---
> I sent this patch to the e1000-devel list on June 8th, 2010, but
> didn't receive any answer:
> http://sourceforge.net/mailarchive/forum.php?thread_name=201006081820.25381.jdelvare%40suse.de&forum_name=e1000-devel
>
>  drivers/net/e1000e/netdev.c |    2 --
>  1 file changed, 2 deletions(-)
>
> --- a/drivers/net/e1000e/netdev.c
> +++ b/drivers/net/e1000e/netdev.c
> @@ -5557,8 +5557,6 @@ static int __devinit e1000_probe(struct
>        if (err)
>                goto err_sw_init;
>
> -       err = -EIO;
> -
>        memcpy(&hw->mac.ops, ei->mac_ops, sizeof(hw->mac.ops));
>        memcpy(&hw->nvm.ops, ei->nvm_ops, sizeof(hw->nvm.ops));
>        memcpy(&hw->phy.ops, ei->phy_ops, sizeof(hw->phy.ops));
>
> --
> Jean Delvare
> Suse L3

Thanks Jean, sorry for the delayed response.  I have added the patch
to my queue.

-- 
Cheers,
Jeff
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html