lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 22 Jul 2010 10:18:38 -0700 From: ebiederm@...ssion.com (Eric W. Biederman) To: Kay Sievers <kay.sievers@...y.org> Cc: Greg KH <gregkh@...e.de>, Andrew Morton <akpm@...ux-foundation.org>, Greg KH <greg@...ah.com>, "Rafael J. Wysocki" <rjw@...k.pl>, "Maciej W. Rozycki" <macro@...ux-mips.org>, Johannes Berg <johannes@...solutions.net>, netdev <netdev@...r.kernel.org> Subject: Re: [PATCH] Driver-core: Fix bluetooth network device rename regression Kay Sievers <kay.sievers@...y.org> writes: Kay you are full of it. My argument is that this a clear case where aiming for perfection is the enemy of the good. >> --- a/drivers/base/core.c >> +++ b/drivers/base/core.c >> @@ -673,7 +673,7 @@ static struct kobject *get_device_parent(struct device *dev, >> */ >> if (parent == NULL) >> parent_kobj = virtual_device_parent(dev); >> - else if (parent->class) >> + else if (parent->class && (strcmp(dev->class->name, "net") != 0)) > > Since the issue is not a regression, and not even a bug in the core, > it should not be done this way for mainline. Yes the issue is a namespace regression and it has been a regression for the bluetooth network drivers since CONFIG_SYSFS_DEPRECATED was introduced. "ip link set name blarg" Where blarg is an attribute of the bluteooth parent device fails only with CONFIG_SYSFS_DEPRECATED disabled. I reported that regression for the majority of the network devices and the class directories were introduced to avoid this problem, except convoluted logic of when to create a class directory fails to cover a few flavors of network drivers. For the mac80211_hwsim driver I don't care. That isn't real hardware and it is only interesting for testing. For the bluetooth network driver that is real hardware that needs to be made to work. > Please try to fix these drivers instead, or mark the broken for > namespaces, if nobody can fix them right now. Let me get this straight. You believe a non-trival non-obvious complete rewrite of entire subsystems after rc1 is better than a one line bug fix that let's real hardware work for real people? You have had 3 years to do better a better job with the bluetooth driver. Furthermore we fixed the rest of this regression in the core I don't see why we can fix the entirety of it this namespace regression in the core. Especially since it is an obviously correct one line change. Eric -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists