lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 23 Jul 2010 08:58:22 +0200 From: Eric Dumazet <eric.dumazet@...il.com> To: Changli Gao <xiaosuo@...il.com> Cc: Patrick McHardy <kaber@...sh.net>, "David S. Miller" <davem@...emloft.net>, netfilter-devel@...r.kernel.org, netdev@...r.kernel.org Subject: Re: [PATCH] iptables: use skb->len for accounting Le vendredi 23 juillet 2010 à 14:47 +0800, Changli Gao a écrit : > On Fri, Jul 23, 2010 at 2:29 PM, Eric Dumazet <eric.dumazet@...il.com> wrote: > > Le vendredi 23 juillet 2010 à 11:34 +0800, Changli Gao a écrit : > >> iptables: use skb->len for accounting > >> > >> use skb->len for accounting as xt_quota does. > >> > > > > Why ? > > > > This is a gratuitous change, unless you have very strong arguments. > > > > xt_quota is an exception, dont change all others because of it ! > > exception ? Why ? Because it handles all protocols... So skb->len is a shortcut, an approximation if you want. At IPV4 level, ip->tot_len is an exact value. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists