| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 28 Jul 2010 11:36:35 -0400 From: Mike Frysinger <vapier.adi@...il.com> To: Joe Perches <joe@...ches.com> Cc: Michael Hennerich <michael.hennerich@...log.com>, uclinux-dist-devel <uclinux-dist-devel@...ckfin.uclinux.org>, LKML <linux-kernel@...r.kernel.org>, netdev <netdev@...r.kernel.org> Subject: Re: [Uclinux-dist-devel] [PATCH net-next] drivers/net/bfin_mac.c: Use pr_fmt, netdev_<level> On Wed, Jul 28, 2010 at 06:00, Joe Perches wrote: > On Wed, 2010-07-28 at 03:50 -0400, Mike Frysinger wrote: >> On Tue, Jul 27, 2010 at 15:22, Joe Perches wrote: >> > $ ./scripts/checkpatch.pl -f drivers/net/bfin_mac.c | grep "^total:" >> > total: 2 errors, 25 warnings, 1723 lines checked >> > $ ./scripts/checkpatch.pl -f drivers/net/bfin_mac.c | grep "^total:" >> > total: 0 errors, 0 warnings, 1743 lines checked >> i dislike the mixing of whitespace and useful changes >> if they were split, and they worked, then i wouldnt have a problem with them > > Is that a nak or a dislike? if you arent going to bother fixing things, then i guess it's a NAK ;) > Also, is Michael Hennerich actually the maintainer for bfin_mac? > He had been listed as MAINTAINER for over a year but he hasn't > ever written or acked a patch for this file. i dont know what log you're reading, but i see Michael making plenty of changes to this driver -mike -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists