netdev - Re: [REGRESSION] e1000e stopped working [MANUALLY BISECTED]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 28 Jul 2010 18:10:58 -0700
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Maxim Levitsky <maximlevitsky@...il.com>
Cc:	"Tantilov, Emil S" <emil.s.tantilov@...el.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"Allan, Bruce W" <bruce.w.allan@...el.com>,
	"Pieper, Jeffrey E" <jeffrey.e.pieper@...el.com>
Subject: Re: [REGRESSION] e1000e stopped working [MANUALLY BISECTED]

On Wed, Jul 28, 2010 at 00:04, Maxim Levitsky <maximlevitsky@...il.com> wrote:
> On Mon, 2010-07-26 at 03:25 +0300, Maxim Levitsky wrote:
>>
>> This commit, present in net-next, solves the problem:
>>
>> commit 1286950690f0f82ffa504e1e149ee3fdb4c51478
>> Author: Bruce Allan <bruce.w.allan@...el.com>
>> Date:   Mon Jul 26 03:19:38 2010 +0300
>>
>>     e1000e: cleanup e1000_sw_lcd_config_ich8lan()
>>
>>     Do not acquire and release the PHY unnecessarily for parts that return
>>     from this workaround without actually accessing the PHY registers.
>>
>>     Signed-off-by: Bruce Allan <bruce.w.allan@...el.com>
>>     Tested-by: Jeff Pieper <jeffrey.e.pieper@...el.com>
>>     Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
>>     Signed-off-by: David S. Miller <davem@...emloft.net>
>>
>>
>>
>>
>> Also, the above patch is part of whole series of patches with scary descriptions (that is these fix bugs).
>> If I were you I would send them to Linus for 2.6.35 inclusion too.
>>
>> Best regards,
>>       Maxim Levitsky
>>
>>
>>
> ping
>

Sorry for the delayed response.  I am working on the issue.  Here is
the problem I am having, the patch that fixes the issue you are seeing
is fairly large and is a cleanup to the ich8 function, which as it
stands now, would not be accepted into net-2.6 tree this late into the
-rc cycle.  So, what I looking at is, what specifically fixed the
issue you are seeing that resides in that patch, and come up with a
smaller (acceptable) patch that I can submit to net-2.6 now to resolve
your issue.

I have dedicated most of this evening to finding a resolution to your
issue that will be acceptable for the net-2.6 tree.  As you noted,
there were several patches before this particular commit that may play
some part in the resolution as well, and that is what I will be
looking into.  I greatly appreciate the hard work you have done to
help us resolve this issue, and will make sure you get credit for any
solution I put together to resolve this issue.

-- 
Cheers,
Jeff
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html