lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 30 Jul 2010 22:20:34 -0700 (PDT) From: David Miller <davem@...emloft.net> To: henrique.camargo@...itec.com.br Cc: chaithrika@...com, srk@...com, khilman@...prootsystems.com, jpirko@...hat.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, segooon@...il.com Subject: Re: [PATCH] drivers: Fixes a typo from "dev" to "ndev" that caused compilation erros. From: Henrique Camargo <henrique.camargo@...itec.com.br> Date: Thu, 29 Jul 2010 12:51:49 -0300 > From: Henrique Camargo >From lines need valid email addresses. But in this case since you are the person who wrote the patch, adding another From: tag in the message body is superfluous and you can just omit it. > diff --git a/drivers/net/davinci_emac.c b/drivers/net/davinci_emac.c > index 25e14d2..b89b7bf 100644 > --- a/drivers/net/davinci_emac.c > +++ b/drivers/net/davinci_emac.c > @@ -1182,8 +1182,8 @@ static int emac_net_tx_complete(struct emac_priv *priv, > struct net_device *ndev = priv->ndev; > u32 cnt; > > - if (unlikely(num_tokens && netif_queue_stopped(dev))) > - netif_start_queue(dev); > + if (unlikely(num_tokens && netif_queue_stopped(ndev))) > + netif_start_queue(ndev); Your patch is corrupted, tab characters have been turned into spaces by your email client. This makes your patch unusable. Please fix up these errors and resubmit your patch. Thank you. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists