netdev - Re: [PATCH 4/6] au1000-eth: fix bad printk usages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 09 Aug 2010 15:17:21 -0700
From:	Joe Perches <joe@...ches.com>
To:	Florian Fainelli <florian@...nwrt.org>
Cc:	netdev@...r.kernel.org, David Miller <davem@...emloft.net>
Subject: Re: [PATCH 4/6] au1000-eth: fix bad printk usages

On Mon, 2010-08-09 at 22:03 +0200, Florian Fainelli wrote:
> Use pr_(info|err) and pr_cont where required instead of calls to printk.
> 
> Signed-off-by: Florian Fainelli <florian@...nwrt.org>
> ---
> diff --git a/drivers/net/au1000_eth.c b/drivers/net/au1000_eth.c
> index 9a0515d..f8f1f5e 100644
> --- a/drivers/net/au1000_eth.c
> +++ b/drivers/net/au1000_eth.c
> @@ -732,24 +732,25 @@ static int au1000_rx(struct net_device *dev)
>  			netif_rx(skb);	/* pass the packet to upper layers */
>  		} else {
>  			if (au1000_debug > 4) {
> +				pr_err("rx_error: ");

This should be:

				pr_err("rx_error(s):");

>  				if (status & RX_MISSED_FRAME)
> -					printk("rx miss\n");
> +					pr_cont("rx miss\n");

These blocks should be "pr_cont(" value");

with a leading space and without the "\n"

>  				if (status & RX_WDOG_TIMER)
> -					printk("rx wdog\n");
> +					pr_cont("rx wdog\n");

[etc]

>  				if (status & RX_U_CNTRL_FRAME)
> -					printk("rx u control frame\n");
> +					pr_cont("rx u control frame\n");

and finally a pr_cont("\n");

It'd also be good to add 

#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt

before any #include


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html