netdev - Re: [PATCH v2] net: add Fast Ethernet driver for PXA168.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 10 Aug 2010 11:12:45 -0700
From:	Philip Rakity <prakity@...vell.com>
To:	Lennert Buytenhek <buytenh@...tstofly.org>
CC:	Sachin Sanap <ssanap@...vell.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Ashish Karkare <akarkare@...vell.com>,
	Prabhanjan Sarnaik <sarnaik@...vell.com>,
	"eric.y.miao@...il.com" <eric.y.miao@...il.com>,
	Mark Brown <markb@...vell.com>
Subject: Re: [PATCH v2]  net: add Fast Ethernet driver for PXA168.



Maybe the solution is to add a new option in Kconfig to define the extra headers size the driver will need.  That option will increase the headers.  I do not like that very much since it requires someone know how big the value should be.  Could default it to 48 or 64 bytes and allow it to be edited.   It is not great solution since it fixes the pxa168 driver but does not handle other drivers.  

thoughts ?



On Aug 10, 2010, at 11:01 AM, Lennert Buytenhek wrote:

> On Tue, Aug 10, 2010 at 10:55:02AM -0700, Philip Rakity wrote:
> 
>> We agree that extra header prepend space is needed.  The solution of
>> globally defining SKB_NET_PAD to increase this area for all drivers
>> is where I have some concern.  The solution certainly works but at
>> the cost of extra space for drivers that do not need to do this.
>> The solution is fine by me and maybe the best answer is to increase
>> the value in the standard linux implementation from 32 to 48 or 64 bytes. 
> 
> What I said was:
> 
> | This seems like something that, should you want to handle it, should be
> | handled centrally (e.g. by conditionally increasing NET_SKB_PAD or so)
> | and not hardcoded into one specific driver only.
> 
> In other words, "don't hardcode it into your driver just because you
> think that most users will want to use your driver for bridging/routing
> to wlan".
> 
> It makes no sense to categorically declare that "pxa168_eth will always
> be used for routing to wireless, so we'll add some extra headroom by
> default there, but e1000e will not, so there we won't".
> 
> Even if this stays a private kernel tree hack, I would still do it
> globally rather than locally.
> 
> 
>>>> 11n needs more.
>>> 
>>> Really?  Pointer?
> 
> Still curious about this.

will forward pointer reference later (on another computer)

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html