netdev - Re: [PATCH] iproute2: dont filter cached routes on iproute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 12 Aug 2010 11:12:12 +0200
From:	Fabio Comolli <fabio.comolli@...il.com>
To:	Ulrich Weber <uweber@...aro.com>
Cc:	Andreas Henriksson <andreas@...al.se>, shemminger@...tta.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH] iproute2: dont filter cached routes on iproute_get

Hi.
Is this patch supposed to be applied on top of plain iproute2 v2.6.35
or on top of the previous Andreas' patch?



On Thu, Aug 12, 2010 at 11:05 AM, Ulrich Weber <uweber@...aro.com> wrote:
> iproute_get will return cloned routes for IPv4
> and cloned as well non-cloned routes for IPv6.
>
> Therefore RTM_F_CLONED flag should not be checked
> for iproute_get routes. Check in print_route will
> always fail because valid values are 0 and 1.
>
> Signed-off-by: Ulrich Weber <uweber@...aro.com>
> ---
>  ip/iproute.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/ip/iproute.c b/ip/iproute.c
> index 711576e..b43933c 100644
> --- a/ip/iproute.c
> +++ b/ip/iproute.c
> @@ -1286,6 +1286,7 @@ int iproute_get(int argc, char **argv)
>        memset(&req, 0, sizeof(req));
>
>        iproute_reset_filter();
> +       filter.cloned = 2;
>
>        req.n.nlmsg_len = NLMSG_LENGTH(sizeof(struct rtmsg));
>        req.n.nlmsg_flags = NLM_F_REQUEST;
> --
> 1.7.0.4
>
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html