lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 12 Aug 2010 07:48:50 -0700 From: Joe Perches <joe@...ches.com> To: Florian Fainelli <florian@...nwrt.org> Cc: netdev@...r.kernel.org, David Miller <davem@...emloft.net> Subject: Re: [PATCH 3/6 v2] au1000-eth: fix all "line over 80 characters warnings" On Thu, 2010-08-12 at 10:09 +0200, Florian Fainelli wrote: > --- a/drivers/net/au1000_eth.c > +++ b/drivers/net/au1000_eth.c > @@ -377,12 +377,15 @@ static int au1000_mii_probe(struct net_device *dev) > - for (phy_addr = 0; phy_addr < PHY_MAX_ADDR; phy_addr++) > + /* find the first (lowest address) PHY > + * on the current MAC's MII bus */ > + for (phy_addr = 0; > + phy_addr < PHY_MAX_ADDR; phy_addr++) Breaking up the for is not an improvement, it's already < 80 > @ -390,22 +393,26 @@ static int au1000_mii_probe(struct net_device *dev) > if (!phydev && (aup->mac_id == 1)) { > /* no PHY found, maybe we have a dual PHY? */ > dev_info(&dev->dev, ": no PHY found on MAC1, " > - "let's see if it's attached to MAC0...\n"); > + "let's see if it's attached to MAC0..." > + "\n"); Definitely not an improvement. > > - /* find the first (lowest address) non-attached PHY on > - * the MAC0 MII bus */ > - for (phy_addr = 0; phy_addr < PHY_MAX_ADDR; phy_addr++) { > + /* find the first (lowest address) non-attached > + * PHY on the MAC0 MII bus */ > + for (phy_addr = 0; phy_addr < PHY_MAX_ADDR; > + phy_addr++) { > struct phy_device *const tmp_phydev = > - aup->mii_bus->phy_map[phy_addr]; > + aup->mii_bus->phy_map[phy_addr]; > > if (aup->mac_id == 1) > break; Can you find a way to reduce the indentation level instead? > @@ -709,7 +719,8 @@ static int au1000_rx(struct net_device *dev) > frmlen -= 4; /* Remove FCS */ > skb = dev_alloc_skb(frmlen + 2); > if (skb == NULL) { > - netdev_err(dev, "Memory squeeze, dropping packet.\n"); > + netdev_err(dev, "Memory squeeze," > + " dropping packet.\n"); Not an improvement. etc... > + netif_dbg(aup, drv, dev, "au1000_multicast_list: flags=%x\n", > + dev->flags); [] > + dev_err(&pdev->dev, "failed to request memory region for" > + " base registers\n"); [] > + dev_err(&pdev->dev, "failed to request memory region for" > + " MAC enable register\n"); [] > dev_err(&pdev->dev, "MAC0-associated PHY attached 2nd MACs MII" > - "bus not supported yet\n"); > + " bus not supported yet\n"); -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists