lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 19 Aug 2010 12:11:12 -0400 From: Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca> To: Eric Dumazet <eric.dumazet@...il.com> Cc: Changli Gao <xiaosuo@...il.com>, Patrick McHardy <kaber@...sh.net>, "David S. Miller" <davem@...emloft.net>, netfilter-devel@...r.kernel.org, netdev@...r.kernel.org Subject: Re: [PATCH v2] netfilter: save the hash of the tuple in the original direction for latter use * Eric Dumazet (eric.dumazet@...il.com) wrote: > Le jeudi 19 août 2010 à 23:35 +0800, Changli Gao a écrit : > > > > > In fact, I don't know the reason clearly. This code is derived from > > the older one. Maybe there isn't enough entropy when initializing. > > > > Yes, we wanted to initialize these random data as late as possible, that > is when the first entry is added in conntrack hash. Ah, I see. But I think the static variable should stay declared outside of the function scope, with a nice comment explaining why it's not initialized at init-time. Hiding global state in function code is usually frowned upon. Thanks, Mathieu -- Mathieu Desnoyers Operating System Efficiency R&D Consultant EfficiOS Inc. http://www.efficios.com -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists