netdev - Re: ip_tables.h can't be used in C++ programs.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 20 Aug 2010 16:42:59 -0700
From:	Ben Greear <greearb@...delatech.com>
To:	Ben Hutchings <bhutchings@...arflare.com>
CC:	NetDev <netdev@...r.kernel.org>
Subject: Re: ip_tables.h can't be used in C++ programs.

On 08/20/2010 04:17 PM, Ben Hutchings wrote:
> On Fri, 2010-08-20 at 11:54 -0700, Ben Greear wrote:
>> This method returns void* but is defined to return
>> a pointer to struct ipt_entry_target.
>>
>> This will not compile under g++ (or, I'm unable to figure out
>> how to make it work w/out editing the header file).
>>
>> Any reason this shouldn't be changed to:
>>
>>    return (struct ipt_entry_target*)e + e->target_offset;
>
> Because that multiplies the offset by sizeof(struct ipt_entry_target)!
>
>> /* Helper functions */
>> static __inline__ struct ipt_entry_target *
>> ipt_get_target(struct ipt_entry *e)
>> {
>>           return (void *)e + e->target_offset;
>> }
>
> For extra unportability, this is relying on the gcc extension for void
> pointer arithmetic.  Try something like:
>
> 	return (struct ipt_entry_target *)((char *)e + e->target_offset);

That compiles fine for me, would be great to get something like
that upstream!

Take it easy,
Ben

-- 
Ben Greear <greearb@...delatech.com>
Candela Technologies Inc  http://www.candelatech.com

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html