netdev - Re[2]: [PATCH v8] PPTP: PPP over IPv4 (Point-to-Point Tunneling Protocol)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 22 Aug 2010 11:17:45 +0400
From:	Dmitry Kozlov <xeb@...l.ru>
To:	David Miller <davem@...emloft.net>
Cc:	xiaosuo@...il.com, eric.dumazet@...il.com, netdev@...r.kernel.org
Subject: Re[2]: [PATCH v8] PPTP: PPP over IPv4 (Point-to-Point Tunneling Protocol)

> From: David Miller <davem@...emloft.net>
> Date: Sat, 21 Aug 2010 23:01:29 -0700 (PDT)
> 
> > From: Changli Gao <xiaosuo@...il.com>
> > Date: Sat, 21 Aug 2010 20:42:09 +0800
> > 
> >> I think the following lines from your patch are also useful, and you'd
> >> better move them above the "---" marker.
> > 
> > I'll take care of this when applying his patch.
> > 
> > Also this patch was against net-2.6 or even something
> > earlier, so there were many patch rejects I had to fix
> > up against include/linux/if_pppox.h when applying this
> > to net-next-2.6
> 
> It also doesn't even build against anything even remotely
> recent:
> 
> drivers/net/pptp.c: In function ?pptp_xmit?:
> drivers/net/pptp.c:204: error: ?struct rtable? has no member named ?u?
> drivers/net/pptp.c:271: error: ?struct rtable? has no member named ?u?
> drivers/net/pptp.c:279: error: ?struct rtable? has no member named ?u?
> drivers/net/pptp.c:283: error: ?struct rtable? has no member named ?u?
> drivers/net/pptp.c:288: error: ?struct rtable? has no member named ?u?
> drivers/net/pptp.c: In function ?pptp_connect?:
> drivers/net/pptp.c:483: error: ?struct rtable? has no member named ?u?
> drivers/net/pptp.c:485: error: ?struct rtable? has no member named ?u?
> drivers/net/pptp.c: In function ?pptp_init_module?:
> drivers/net/pptp.c:675: error: implicit declaration of function ?__vmalloc?
> drivers/net/pptp.c:676: warning: assignment makes pointer from integer without a cast
> drivers/net/pptp.c:707: error: implicit declaration of function ?vfree?
> 
> That means this patch is against a tree which is at least two
> releases old.  We got rid of the 'u' member of struct rtable
> quite some time ago.
> 
> Ugh, I'll fix this up, but after _8_, yes _EIGHT_, iterations of this
> patch set the amount of problems that remain is completely
> unbelievable.

Sorry, maybe it is wrong, but i did patch using repository git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git, HEAD at a63ecd835f075b21d7d5cef9580447f5fbb36263.
Have i update and resend it for net-next-2.6 ?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html