netdev - Re: [PATCH net-next-2.6 v3] gro: __napi_gro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 27 Aug 2010 06:43:44 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, herbert@...dor.apana.org.au
Subject: Re: [PATCH net-next-2.6 v3] gro: __napi_gro_receive() optimizations

Le jeudi 26 août 2010 à 21:38 -0700, David Miller a écrit :
> From: Eric Dumazet <eric.dumazet@...il.com>
> Date: Fri, 27 Aug 2010 06:35:13 +0200
> 
> > +	fold |= *(unsigned long *)(a + 6) ^ *(unsigned long *)(b + 6);
> 
> Shouldn't these be "+ 8" instead of "+ 6"?

Not really, we want to compare 14 bytes, not 16

So we have (sizeof(long) + sizeof(long)) - intersection

I guess I should comment this :)


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html