netdev - Re: [PATCH net-next-2.6] skge: add GRO support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 31 Aug 2010 18:31:05 -0700
From:	Stephen Hemminger <shemminger@...tta.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	David Miller <davem@...emloft.net>, netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next-2.6] skge: add GRO support

On Wed, 01 Sep 2010 00:32:36 +0200
Eric Dumazet <eric.dumazet@...il.com> wrote:

> @@ -3193,7 +3192,7 @@ static int skge_poll(struct napi_struct *napi, int to_do)
>  		unsigned long flags;
>  
>  		spin_lock_irqsave(&hw->hw_lock, flags);
> -		__napi_complete(napi);
> +		napi_complete(napi);

This adds a redundant irq_save/irq_restore in the packet
receive path.

In the case of skge, since the both ports share a single
IRQ mask register, the lock is there to make sure that updates
to the mask register doesn't race between NAPI finishing
on one port and IRQ on other port changing same IRQ mask register.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html